third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js - Issue 2609653002: [DevTools] Migrate CallStackSidebarPane to UI.ListControl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

Issue 2609653002: [DevTools] Migrate CallStackSidebarPane to UI.ListControl. (Closed)

Patch Set: comments addressed, more fixes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js ('K') | « third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css ('k') | third_party/WebKit/Source/devtools/front_end/ui/ListControl.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

index 5cd522b66e58718ec6d71858a83f5703e5623d0b..7cfc55021f9ed2dfd0487adaa8c0646d821e81ec 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

@@ -146,7 +146,8 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {

this._networkView.addEventListener(PerfUI.FlameChart.Events.EntrySelected, this._onNetworkEntrySelected, this);

this._nextExtensionIndex = 0;

- Bindings.blackboxManager.addChangeListener(this.refreshRecords, this);

+ this._boundRefresh = this.refreshRecords.bind(this);

+ Bindings.blackboxManager.addChangeListener(this._boundRefresh);

}

/**

@@ -155,7 +156,7 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {

dispose() {

this._mainView.removeEventListener(PerfUI.FlameChart.Events.EntrySelected, this._onMainEntrySelected, this);

this._networkView.removeEventListener(PerfUI.FlameChart.Events.EntrySelected, this._onNetworkEntrySelected, this);

- Bindings.blackboxManager.removeChangeListener(this.refreshRecords, this);

+ Bindings.blackboxManager.removeChangeListener(this._boundRefresh);

}

/**