third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html - Issue 2609653002: [DevTools] Migrate CallStackSidebarPane to UI.ListControl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html

Issue 2609653002: [DevTools] Migrate CallStackSidebarPane to UI.ListControl. (Closed)

Patch Set: comments addressed, more fixes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-async-function.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/copy-stack-trace-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html

index 86e8faaa28cd948e6ef9d952a6d2124467588e3d..8a06b992d67576c8e771c17b68489abf34087d07 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html

@@ -44,9 +44,9 @@ var test = function()

function step6()

{

- var callFrameList = self.runtime.sharedInstance(Sources.CallStackSidebarPane).callFrameList;

- for (var item of callFrameList._items)

- InspectorTest.addResult(item.element.textContent.replace(/VM\d+/g, "VM"));

+ var pane = self.runtime.sharedInstance(Sources.CallStackSidebarPane);

+ for (var element of pane.contentElement.querySelectorAll('.call-frame-item'))

+ InspectorTest.addResult(element.deepTextContent().replace(/VM\d+/g, "VM"));

InspectorTest.completeDebuggerTest();

}