Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

Issue 2609653002: [DevTools] Migrate CallStackSidebarPane to UI.ListControl. (Closed)
Patch Set: comments addressed, more fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 Timeline.FlameChartStyle = { 5 Timeline.FlameChartStyle = {
6 textColor: '#333' 6 textColor: '#333'
7 }; 7 };
8 8
9 /** 9 /**
10 * @enum {symbol} 10 * @enum {symbol}
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 this._splitWidget.setMainWidget(this._mainView); 139 this._splitWidget.setMainWidget(this._mainView);
140 this._splitWidget.setSidebarWidget(networkPane); 140 this._splitWidget.setSidebarWidget(networkPane);
141 this._splitWidget.show(this.element); 141 this._splitWidget.show(this.element);
142 142
143 this._onMainEntrySelected = this._onEntrySelected.bind(this, this._dataProvi der); 143 this._onMainEntrySelected = this._onEntrySelected.bind(this, this._dataProvi der);
144 this._onNetworkEntrySelected = this._onEntrySelected.bind(this, this._networ kDataProvider); 144 this._onNetworkEntrySelected = this._onEntrySelected.bind(this, this._networ kDataProvider);
145 this._mainView.addEventListener(PerfUI.FlameChart.Events.EntrySelected, this ._onMainEntrySelected, this); 145 this._mainView.addEventListener(PerfUI.FlameChart.Events.EntrySelected, this ._onMainEntrySelected, this);
146 this._networkView.addEventListener(PerfUI.FlameChart.Events.EntrySelected, t his._onNetworkEntrySelected, this); 146 this._networkView.addEventListener(PerfUI.FlameChart.Events.EntrySelected, t his._onNetworkEntrySelected, this);
147 this._nextExtensionIndex = 0; 147 this._nextExtensionIndex = 0;
148 148
149 Bindings.blackboxManager.addChangeListener(this.refreshRecords, this); 149 this._boundRefresh = this.refreshRecords.bind(this);
150 Bindings.blackboxManager.addChangeListener(this._boundRefresh);
150 } 151 }
151 152
152 /** 153 /**
153 * @override 154 * @override
154 */ 155 */
155 dispose() { 156 dispose() {
156 this._mainView.removeEventListener(PerfUI.FlameChart.Events.EntrySelected, t his._onMainEntrySelected, this); 157 this._mainView.removeEventListener(PerfUI.FlameChart.Events.EntrySelected, t his._onMainEntrySelected, this);
157 this._networkView.removeEventListener(PerfUI.FlameChart.Events.EntrySelected , this._onNetworkEntrySelected, this); 158 this._networkView.removeEventListener(PerfUI.FlameChart.Events.EntrySelected , this._onNetworkEntrySelected, this);
158 Bindings.blackboxManager.removeChangeListener(this.refreshRecords, this); 159 Bindings.blackboxManager.removeChangeListener(this._boundRefresh);
159 } 160 }
160 161
161 /** 162 /**
162 * @override 163 * @override
163 * @return {?Element} 164 * @return {?Element}
164 */ 165 */
165 resizerElement() { 166 resizerElement() {
166 return null; 167 return null;
167 } 168 }
168 169
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 Timeline.TimelineFlameChartView.Selection = class { 316 Timeline.TimelineFlameChartView.Selection = class {
316 /** 317 /**
317 * @param {!Timeline.TimelineSelection} selection 318 * @param {!Timeline.TimelineSelection} selection
318 * @param {number} entryIndex 319 * @param {number} entryIndex
319 */ 320 */
320 constructor(selection, entryIndex) { 321 constructor(selection, entryIndex) {
321 this.timelineSelection = selection; 322 this.timelineSelection = selection;
322 this.entryIndex = entryIndex; 323 this.entryIndex = entryIndex;
323 } 324 }
324 }; 325 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698