runtime/vm/runtime_entry.cc - Issue 2609643002: 1. Avoid potential dead lock due to lock-order-inversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/runtime_entry.cc

Issue 2609643002: 1. Avoid potential dead lock due to lock-order-inversion (Closed)

Patch Set: Address code review changes. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/runtime_entry.cc

diff --git a/runtime/vm/runtime_entry.cc b/runtime/vm/runtime_entry.cc

index b0cd46ed36442dae67d45420a31d9e4fbb2bb1cb..860f0486a8a583e65bbb0bc8ce47d3e666cadf1c 100644

--- a/runtime/vm/runtime_entry.cc

+++ b/runtime/vm/runtime_entry.cc

@@ -14,7 +14,7 @@ namespace dart {

void VerifyOnTransition() {

Thread* thread = Thread::Current();

TransitionGeneratedToVM transition(thread);

- thread->isolate()->heap()->WaitForSweeperTasks();

+ thread->isolate()->heap()->WaitForSweeperTasks(thread);

SafepointOperationScope safepoint_scope(thread);

VerifyPointersVisitor::VerifyPointers();

thread->isolate()->heap()->Verify();

« no previous file with comments | « runtime/vm/precompiler.cc ('k') | no next file » | no next file with comments »