Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2609633002: Make EventStreamSubscription DDC safe. (Closed)

Created:
3 years, 11 months ago by Leaf
Modified:
3 years, 11 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make EventStreamSubscription DDC safe. EventStreamSubscription.listen does a cast which is only working in DDC because we're ignoring the failure. This wraps the listener to check the argument rather than casting the function. Also picks up a few misc changes to the main SDK that hadn't been merged into DDC. BUG= R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/7ab0daeedf69a531497cb981bae364629ac87085

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -108 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 6 chunks +12 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 6 chunks +12 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 6 chunks +12 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 6 chunks +12 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart View 7 chunks +29 lines, -19 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 2 chunks +1 line, -3 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 chunks +16 lines, -18 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +16 lines, -18 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 chunk +14 lines, -6 lines 0 comments Download
M tools/dom/src/shared_html.dart View 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
3 years, 11 months ago (2016-12-29 23:42:10 UTC) #2
Jacob
lgtm
3 years, 11 months ago (2017-01-03 15:23:39 UTC) #3
Leaf
3 years, 11 months ago (2017-01-09 12:13:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7ab0daeedf69a531497cb981bae364629ac87085 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698