Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 260963012: Override repaintTreeAfterLayout for RenderSVGModelObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update TestExpectations. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1502 matching lines...) Expand 10 before | Expand all | Expand 10 after
1513 void RenderObject::repaintTreeAfterLayout() 1513 void RenderObject::repaintTreeAfterLayout()
1514 { 1514 {
1515 clearRepaintState(); 1515 clearRepaintState();
1516 1516
1517 for (RenderObject* child = firstChild(); child; child = child->nextSibling() ) { 1517 for (RenderObject* child = firstChild(); child; child = child->nextSibling() ) {
1518 if (!child->isOutOfFlowPositioned()) 1518 if (!child->isOutOfFlowPositioned())
1519 child->repaintTreeAfterLayout(); 1519 child->repaintTreeAfterLayout();
1520 } 1520 }
1521 } 1521 }
1522 1522
1523 void RenderObject::repaintScrollbarsIfNeeded()
1524 {
1525 // Repaint any scrollbars if there is a scrollable area for this renderer.
1526 if (RenderLayerScrollableArea* area = enclosingLayer() ? enclosingLayer()->s crollableArea() : 0) {
Julien - ping for review 2014/05/05 16:34:37 Nit: I would use an early return here to avoid the
fs 2014/05/05 17:33:06 Done.
1527 if (area->hasVerticalBarDamage())
1528 repaintRectangle(area->verticalBarDamage());
1529 if (area->hasHorizontalBarDamage())
1530 repaintRectangle(area->horizontalBarDamage());
1531 area->resetScrollbarDamage();
1532 }
1533 }
1534
1523 static PassRefPtr<JSONValue> jsonObjectForOldAndNewRects(const LayoutRect& oldRe ct, const LayoutRect& newRect) 1535 static PassRefPtr<JSONValue> jsonObjectForOldAndNewRects(const LayoutRect& oldRe ct, const LayoutRect& newRect)
1524 { 1536 {
1525 RefPtr<JSONObject> object = JSONObject::create(); 1537 RefPtr<JSONObject> object = JSONObject::create();
1526 1538
1527 object->setValue("old", jsonObjectForRect(oldRect)); 1539 object->setValue("old", jsonObjectForRect(oldRect));
1528 object->setValue("new", jsonObjectForRect(newRect)); 1540 object->setValue("new", jsonObjectForRect(newRect));
1529 return object.release(); 1541 return object.release();
1530 } 1542 }
1531 1543
1532 bool RenderObject::repaintAfterLayoutIfNeeded(const RenderLayerModelObject* repa intContainer, bool wasSelfLayout, 1544 bool RenderObject::repaintAfterLayoutIfNeeded(const RenderLayerModelObject* repa intContainer, bool wasSelfLayout,
(...skipping 1892 matching lines...) Expand 10 before | Expand all | Expand 10 after
3425 { 3437 {
3426 if (object1) { 3438 if (object1) {
3427 const WebCore::RenderObject* root = object1; 3439 const WebCore::RenderObject* root = object1;
3428 while (root->parent()) 3440 while (root->parent())
3429 root = root->parent(); 3441 root = root->parent();
3430 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3442 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3431 } 3443 }
3432 } 3444 }
3433 3445
3434 #endif 3446 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698