cc/resources/tile_manager_perftest.cc - Issue 260963008: Fixing crash in PictureLayerImpl::MarkVisibleResourcesAsRequired when low-res tiles are disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/tile_manager_perftest.cc

Issue 260963008: Fixing crash in PictureLayerImpl::MarkVisibleResourcesAsRequired when low-res tiles are disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactoring and more unittests for low res disabled. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/tile_manager_perftest.cc

diff --git a/cc/resources/tile_manager_perftest.cc b/cc/resources/tile_manager_perftest.cc

index 9a1642ae27cbfc6df66bdde06407dbaec3717015..47b52d95f55bce979d576c5a199f5c0a2204344b 100644

--- a/cc/resources/tile_manager_perftest.cc

+++ b/cc/resources/tile_manager_perftest.cc

@@ -13,7 +13,6 @@

#include "cc/test/fake_picture_pile_impl.h"

#include "cc/test/fake_tile_manager.h"

#include "cc/test/fake_tile_manager_client.h"

-#include "cc/test/impl_side_painting_settings.h"

#include "cc/test/lap_timer.h"

#include "cc/test/test_shared_bitmap_manager.h"

#include "cc/test/test_tile_priorities.h"

@@ -204,7 +203,7 @@ class TileManagerTileIteratorPerfTest : public testing::Test,

ready_to_activate_(false),

id_(7),

proxy_(base::MessageLoopProxy::current()),

- host_impl_(ImplSidePaintingSettings(),

+ host_impl_(LayerTreeSettings(true),

&proxy_,

&shared_bitmap_manager_),

timer_(kWarmupRuns,

« cc/layers/picture_layer_impl_unittest.cc ('K') | « cc/layers/picture_layer_unittest.cc ('k') | cc/resources/tile_manager_unittest.cc » ('j') | cc/test/impl_side_painting_settings.h » ('J')