Fixing crash in PictureLayerImpl::MarkVisibleResourcesAsRequired when low-res tiles are disabled

cc/trees/layer_tree_settings.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TREES_LAYER_TREE_SETTINGS_H_
 #define CC_TREES_LAYER_TREE_SETTINGS_H_
 
 #include "base/basictypes.h"
 #include "cc/base/cc_export.h"
 #include "cc/debug/layer_tree_debug_state.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/size.h"
 
 namespace cc {
 
 class CC_EXPORT LayerTreeSettings {
  public:
-  LayerTreeSettings();
+  LayerTreeSettings(
+      bool impl_side_painting_ = false,
+      bool create_low_res_tiling_ = true
+  );

[reveman, 2014/05/13 15:38:05]

Not sure we should do this. Why should these settings be singled out and
adjustable using the ctor? If we add everything, then that would result in
cryptic calls to this ctor. I think it's better to keep the default ctor not
take any arguments and instead set them for each test case. Possible create some
derived class such as ImplSidePaintingSettings where convenient but keep those
in an anonymous namespace when possible.

[Sergey, 2014/05/14 05:53:35]

Done.

   ~LayerTreeSettings();
 
   bool impl_side_painting;
   bool allow_antialiasing;
   bool throttle_frame_production;
   bool begin_impl_frame_scheduling_enabled;
   bool main_frame_before_draw_enabled;
   bool main_frame_before_activation_enabled;
   bool using_synchronous_renderer_compositor;
   bool report_overscroll_only_for_scrollable_axes;
@@ skipping 47 matching lines @@
   bool use_rgba_4444_textures;
   bool touch_hit_testing;
   size_t texture_id_allocation_chunk_size;
 
   LayerTreeDebugState initial_debug_state;
 };
 
 }  // namespace cc
 
 #endif  // CC_TREES_LAYER_TREE_SETTINGS_H_