Fixing crash in PictureLayerImpl::MarkVisibleResourcesAsRequired when low-res tiles are disabled

cc/test/fake_layer_tree_settings.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_TEST_FAKE_LAYER_TREE_SETTINGS_H_
+#define CC_TEST_FAKE_LAYER_TREE_SETTINGS_H_
+
+#include "cc/trees/layer_tree_settings.h"
+
+namespace cc {
+
+class FakeLayerTreeSettings : public LayerTreeSettings {

[reveman, 2014/05/12 02:30:52]

why not change ImplSidePaintingSettings instead of adding a new class?

[Sergey, 2014/05/12 08:07:21]

Judging from ImplSidePaintingSettings class name, I thought that it would not be
good to use this class to actually change some other settings in constructor. So
I thought more general purpose class name would be better, as in the future
there might be a need to add some more settings changes into the settings class
for unit testing.

If we will use ImplSidePaintingSettings we might end up writing
explanations/excuses like "the name goes from previous versions..", about a
class, that has a lot of setting changes.

[reveman, 2014/05/12 15:44:04]

You should probably remove ImplSidePaintingSettings in that case. Not clear to
me why we need a separate class for this at all though. Can't we just use
LayerTreeSettings directly? I assume ImplSidePaintingSettings was just added as
a convenience until impl-side painting has become default. That makes some sense
as it's so commonly used but adding derived classes for adjusting other setting
seems overkill imo.

[Sergey, 2014/05/12 23:37:47]

Agree on that, let's make some refactoring :)

[Sergey, 2014/05/13 05:37:44]

Done.

+ public:
+  FakeLayerTreeSettings() {
+    impl_side_painting = true;
+    create_low_res_tiling = true;
+  }
+
+  FakeLayerTreeSettings(bool create_low_res_tiling_) {
+    impl_side_painting = true;
+    create_low_res_tiling = create_low_res_tiling_;
+  }
+
+};
+
+}  // namespace cc
+
+#endif  // CC_TEST_FAKE_LAYER_TREE_SETTINGS_H_