Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Side by Side Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2609593002: MD Settings: Internet: Minor fixes (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-internet-detail' is the settings subpage containing details 7 * 'settings-internet-detail' is the settings subpage containing details
8 * for a network. 8 * for a network.
9 */ 9 */
10 (function() { 10 (function() {
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 }, 452 },
453 453
454 /** @private */ 454 /** @private */
455 onDisconnectTap_: function() { 455 onDisconnectTap_: function() {
456 this.networkingPrivate.startDisconnect(this.guid); 456 this.networkingPrivate.startDisconnect(this.guid);
457 }, 457 },
458 458
459 /** @private */ 459 /** @private */
460 onForgetTap_: function() { 460 onForgetTap_: function() {
461 this.networkingPrivate.forgetNetwork(this.guid); 461 this.networkingPrivate.forgetNetwork(this.guid);
462 // A forgotten WiFi network can still be configured, but not other types. 462 // A forgotten network no longer has a valid GUID, close the subpage.
463 if (this.networkProperties.Type != CrOnc.Type.WI_FI) 463 this.close_();
464 this.close_();
465 }, 464 },
466 465
467 /** @private */ 466 /** @private */
468 onActivateTap_: function() { 467 onActivateTap_: function() {
469 this.networkingPrivate.startActivate(this.guid); 468 this.networkingPrivate.startActivate(this.guid);
470 }, 469 },
471 470
472 /** @private */ 471 /** @private */
473 onConfigureTap_: function() { 472 onConfigureTap_: function() {
474 chrome.send('configureNetwork', [this.guid]); 473 chrome.send('configureNetwork', [this.guid]);
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 */ 811 */
813 allPropertiesMatch_: function(curValue, newValue) { 812 allPropertiesMatch_: function(curValue, newValue) {
814 for (let key in newValue) { 813 for (let key in newValue) {
815 if (newValue[key] != curValue[key]) 814 if (newValue[key] != curValue[key])
816 return false; 815 return false;
817 } 816 }
818 return true; 817 return true;
819 } 818 }
820 }); 819 });
821 })(); 820 })();
OLDNEW
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698