Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: extensions/renderer/api_bindings_system_unittest.cc

Issue 2609553003: [Extensions Bindings] Allow custom hooks to return values, throw (Closed)
Patch Set: woot Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_bindings_system_unittest.cc
diff --git a/extensions/renderer/api_bindings_system_unittest.cc b/extensions/renderer/api_bindings_system_unittest.cc
index 23906077abc11196bd5003127b9e95e529114ed2..59d684f6af2d1cca954da046473c372ecc037540 100644
--- a/extensions/renderer/api_bindings_system_unittest.cc
+++ b/extensions/renderer/api_bindings_system_unittest.cc
@@ -298,7 +298,8 @@ TEST_F(APIBindingsSystemTest, TestCustomHooks) {
auto hook = [](bool* did_call,
const APISignature* signature, v8::Local<v8::Context> context,
std::vector<v8::Local<v8::Value>>* arguments,
- const ArgumentSpec::RefMap& type_refs) {
+ const ArgumentSpec::RefMap& type_refs,
+ v8::Local<v8::Value>* return_value) {
*did_call = true;
if (arguments->size() != 2) { // ASSERT* messes with the return type.
EXPECT_EQ(2u, arguments->size());
« extensions/renderer/api_binding_hooks.h ('K') | « extensions/renderer/api_binding_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698