[Extensions Bindings] Allow custom hooks to return values, throw

extensions/renderer/api_bindings_system_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/api_bindings_system.h"
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/stl_util.h"
@@ skipping 282 matching lines @@
 TEST_F(APIBindingsSystemTest, TestCustomHooks) {
   v8::HandleScope handle_scope(isolate());
   v8::Local<v8::Context> context = ContextLocal();
 
   bool did_call = false;
   auto hook = [](bool* did_call,
                  const APISignature* signature, v8::Local<v8::Context> context,
                  std::vector<v8::Local<v8::Value>>* arguments,
                  const ArgumentSpec::RefMap& type_refs) {
     *did_call = true;
+    APIBindingHooks::RequestResult result(
+        APIBindingHooks::RequestResult::HANDLED);
     if (arguments->size() != 2) {  // ASSERT* messes with the return type.
       EXPECT_EQ(2u, arguments->size());
-      return APIBindingHooks::RequestResult::HANDLED;
+      return result;
     }
     std::string argument;
     EXPECT_EQ("foo", gin::V8ToString(arguments->at(0)));
     if (!arguments->at(1)->IsFunction()) {
       EXPECT_TRUE(arguments->at(1)->IsFunction());
-      return APIBindingHooks::RequestResult::HANDLED;
+      return result;
     }
     v8::Local<v8::String> response =
         gin::StringToV8(context->GetIsolate(), "bar");
     v8::Local<v8::Value> response_args[] = {response};
     RunFunctionOnGlobal(arguments->at(1).As<v8::Function>(),
                         context, 1, response_args);
-    return APIBindingHooks::RequestResult::HANDLED;
+    return result;
   };
 
   APIBindingHooks* hooks = bindings_system()->GetHooksForAPI(kAlphaAPIName);
   ASSERT_TRUE(hooks);
   hooks->RegisterHandleRequest(
       "alpha.functionWithCallback",
       base::Bind(hook, &did_call));
 
   v8::Local<v8::Object> alpha_api = bindings_system()->CreateAPIInstance(
       kAlphaAPIName, context, isolate(), base::Bind(&AllowAllAPIs), nullptr);
@@ skipping 157 matching lines @@
                                                        context, "idleState"));
     bindings_system()->FireEventInContext("idle.onStateChanged", context,
                                           *ListValueFromString("['active']"));
 
     EXPECT_EQ("\"active\"", GetStringPropertyFromObject(context->Global(),
                                                         context, "idleState"));
   }
 }
 
 }  // namespace extensions