Issue 2609433002: Fix rasta unittests: now unit tests need to run the full compiler to use its

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2609433002: Fix rasta unittests: now unit tests need to run the full compiler to use its (Closed)

Created:
3 years, 11 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 11 months ago

Reviewers:
Emily Fortuna, Harry Terkelsen

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix rasta unittests: now unit tests need to run the full compiler to use its resolution queue. Committed: https://github.com/dart-lang/sdk/commit/b8dbee257c67def52c67de5e7708cd1b30571a17

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -6 lines)			Patch
	M	tests/compiler/dart2js/kernel/class_hierarchy_test.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	tests/compiler/dart2js/kernel/visitor_test.dart	View		4 chunks	+21 lines, -4 lines	0 comments	Download

Total messages: 6 (3 generated)

Siggi Cherem (dart-lang)

TBR - this fixes the unit tests that I broke in my previous CL.

3 years, 11 months ago (2016-12-28 17:32:24 UTC) #3

Siggi Cherem (dart-lang)

Committed patchset #1 (id:20001) manually as b8dbee257c67def52c67de5e7708cd1b30571a17 (presubmit successful).

3 years, 11 months ago (2016-12-28 17:32:37 UTC) #5

Message was sent while issue was closed.

lgtm