xfa/fde/cfde_txtedttextset.h - Issue 2609423003: Properly ref-count CFGAS_GEFont with CFX_RetainPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fde/cfde_txtedttextset.h

Issue 2609423003: Properly ref-count CFGAS_GEFont with CFX_RetainPtr. (Closed)

Patch Set: comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fde/cfde_txtedttextset.h

diff --git a/xfa/fde/cfde_txtedttextset.h b/xfa/fde/cfde_txtedttextset.h

index 14979dcf1405178274e184e260b4a54a3493b44b..6c6266642bd8d129d1889f2416aebf6f23bbf6db 100644

--- a/xfa/fde/cfde_txtedttextset.h

+++ b/xfa/fde/cfde_txtedttextset.h

@@ -22,7 +22,7 @@ class CFDE_TxtEdtTextSet : public IFDE_TextSet {

// IFDE_TextSet

int32_t GetString(FDE_TEXTEDITPIECE* pPiece, CFX_WideString& wsText) override;

- CFGAS_GEFont* GetFont() override;

+ CFX_RetainPtr<CFGAS_GEFont> GetFont() override;

FX_FLOAT GetFontSize() override;

FX_ARGB GetFontColor() override;

int32_t GetDisplayPos(FDE_TEXTEDITPIECE* pPiece,