chrome/browser/android/ntp/ntp_snippets_bridge.h - Issue 2609413005: [NTP::SectionOrder] Add category position metric for opened suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.h

Issue 2609413005: [NTP::SectionOrder] Add category position metric for opened suggestions. (Closed)

Patch Set: added TODO. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/ntp/ntp_snippets_bridge.h

diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.h b/chrome/browser/android/ntp/ntp_snippets_bridge.h

index 3b36cce073542d003af2ecf0af23daa0559efd34..a4db74d7c50fe96217fe44d3d3ed3ff1c0974608 100644

--- a/chrome/browser/android/ntp/ntp_snippets_bridge.h

+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.h

@@ -79,7 +79,7 @@ class NTPSnippetsBridge

const base::android::JavaParamRef<jstring>& jurl,

jint global_position,

jint j_category_id,

- jint category_position,

+ jint position_in_category,

const base::android::JavaParamRef<jstring>& id_within_category);

void DismissCategory(JNIEnv* env,

@@ -100,7 +100,7 @@ class NTPSnippetsBridge

const base::android::JavaParamRef<jobject>& obj,

jint global_position,

jint j_category_id,

- jint category_position,

+ jint position_in_category,

jlong publish_timestamp_ms,

jfloat score);

@@ -108,7 +108,7 @@ class NTPSnippetsBridge

const base::android::JavaParamRef<jobject>& obj,

jint global_position,

jint j_category_id,

- jint category_position,

+ jint position_in_category,

jlong publish_timestamp_ms,

jfloat score,

int windowOpenDisposition);

@@ -117,7 +117,7 @@ class NTPSnippetsBridge

const base::android::JavaParamRef<jobject>& obj,

jint global_position,

jint j_category_id,

- jint category_position,

+ jint position_in_category,

jlong publish_timestamp_ms,

jfloat score);

« no previous file with comments | « no previous file | chrome/browser/android/ntp/ntp_snippets_bridge.cc » ('j') | components/ntp_snippets/content_suggestions_metrics.cc » ('J')