Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2609413005: [NTP::SectionOrder] Add category position metric for opened suggestions. (Closed)
Patch Set: propagate category rank from ui. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index 412933c8d45c8d3d677c91bb3ee06da14ebce06f..5d8e27ec9c5bc28a073e613d73764163d037c90b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -306,18 +306,18 @@ public class SnippetsBridge implements SuggestionsSource {
private native void nativeFetch(
long nativeNTPSnippetsBridge, int category, String[] knownSuggestions);
private native void nativeDismissSuggestion(long nativeNTPSnippetsBridge, String url,
- int globalPosition, int category, int categoryPosition, String idWithinCategory);
+ int globalPosition, int category, int positionInCategory, String idWithinCategory);
private native void nativeDismissCategory(long nativeNTPSnippetsBridge, int category);
private native void nativeRestoreDismissedCategories(long nativeNTPSnippetsBridge);
private native void nativeOnPageShown(
long nativeNTPSnippetsBridge, int[] categories, int[] suggestionsPerCategory);
private native void nativeOnSuggestionShown(long nativeNTPSnippetsBridge, int globalPosition,
- int category, int categoryPosition, long publishTimestampMs, float score);
+ int category, int positionInCategory, long publishTimestampMs, float score);
private native void nativeOnSuggestionOpened(long nativeNTPSnippetsBridge, int globalPosition,
- int category, int categoryRank, int categoryPosition, long publishTimestampMs,
+ int category, int categoryRank, int positionInCategory, long publishTimestampMs,
float score, int windowOpenDisposition);
private native void nativeOnSuggestionMenuOpened(long nativeNTPSnippetsBridge,
- int globalPosition, int category, int categoryPosition, long publishTimestampMs,
+ int globalPosition, int category, int positionInCategory, long publishTimestampMs,
float score);
private native void nativeOnMoreButtonShown(
long nativeNTPSnippetsBridge, int category, int position);
« no previous file with comments | « no previous file | chrome/browser/android/ntp/ntp_snippets_bridge.h » ('j') | components/ntp_snippets/content_suggestions_metrics.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698