Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2609413004: Roll buildtools 0ef8010876..8932ecfa42 (Closed)

Created:
3 years, 11 months ago by Dirk Pranke
Modified:
3 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 0ef8010876..8932ecfa42 In order to roll GN c99acd6557..b1f498915e (r439377:r441559) and pick up the following changes: 7e5894a9a070 Configure xctest build settings to prevent Xcode from linking objects. 043a15ddcc6c Add functionality to find xctest files under application target. d1316080967d Stop propagation of dependent configs between toolchains. 0c1dd9de8c00 GN: Fix some typos in the documentation. 67e8c60e4b18 [Refactor Xcode Objects] Allow extra attributes for native targets. 8fb7d9d9c9dd [Refactor Xcode Objects] Enable adding per file '--help' compiler flag. 898a56b7966c [Refactor Xcode Objects] Decouple file references and indexing target. a8936b7a13ff Fix a typo in GN documentation 889ccd0f81e2 Fix a typo in gn help. 7d88638248b1 Support for source_target_relative expansion in GN 615f852746f6 Fix GN bootstrap. d48f4812d853 [Refactor Xcode Objects] Enable navigator paths for file references. 44dbd2f12ae5 Clean up link references in //tools/gn/README.md. TBR=brettw@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Dirk Pranke
3 years, 11 months ago (2017-01-05 02:42:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609413004/1
3 years, 11 months ago (2017-01-05 02:43:08 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 02:51:35 UTC) #5
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

Powered by Google App Engine
This is Rietveld 408576698