Issue 2609393005: Always finalize the super class of a class before cloning the super class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2609393005: Always finalize the super class of a class before cloning the super class (Closed)

Created:
3 years, 11 months ago by regis

Modified:
3 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Always finalize the super class of a class before cloning the super class constructor and cloning the mixin functions. The fragile finalization order was disrupted by the use of the --error-on-bad-override flag (fixes #28252). R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/98f28c1624df830e7735895b54e4de21d94ba0e6

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -23 lines)			Patch
	M	runtime/vm/class_finalizer.cc	View		3 chunks	+34 lines, -23 lines	0 comments	Download

Total messages: 5 (2 generated)

regis

3 years, 11 months ago (2017-01-05 17:09:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
98f28c1624df830e7735895b54e4de21d94ba0e6 (presubmit successful).