Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/ui/webui/BUILD.gn

Issue 2609363003: Remove ChromeBrowserProvider::GetFaviconForURL(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ios/chrome/browser/favicon/BUILD.gn ('K') | « ios/chrome/browser/favicon/favicon_client_impl.mm ('k') | ios/public/provider/chrome/browser/chrome_browser_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/webui/BUILD.gn
diff --git a/ios/chrome/browser/ui/webui/BUILD.gn b/ios/chrome/browser/ui/webui/BUILD.gn
index 456c5ad1ca6b6cdf7a0d139b4a8b80180f0e2e3a..03cfceb19ca64c166b65d81bbd4e91d1405b6183 100644
--- a/ios/chrome/browser/ui/webui/BUILD.gn
+++ b/ios/chrome/browser/ui/webui/BUILD.gn
@@ -73,6 +73,7 @@ source_set("webui_internal") {
"//ios/chrome/app/resources:ios_resources",
"//ios/chrome/browser",
"//ios/chrome/browser/browser_state",
+ "//ios/chrome/browser/favicon",
"//ios/chrome/browser/omaha",
"//ios/chrome/browser/signin",
"//ios/chrome/browser/ui/webui",
@@ -84,6 +85,7 @@ source_set("webui_internal") {
"//ui/gfx",
"//url",
]
+ allow_circular_includes_from = [ "//ios/chrome/browser/favicon" ]
}
source_set("eg_tests") {
« ios/chrome/browser/favicon/BUILD.gn ('K') | « ios/chrome/browser/favicon/favicon_client_impl.mm ('k') | ios/public/provider/chrome/browser/chrome_browser_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698