Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

Issue 2609353002: DevTools: Remove left margin when DevTools is docked (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js b/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
index 9140d9215500c8e9b9aee7305e8c9028eded82b1..8de740664c5bdf9c3804da061530d3c21791be13 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
@@ -37,8 +37,16 @@ UI.SplitWidget = class extends UI.Widget {
* @param {number=} defaultSidebarWidth
* @param {number=} defaultSidebarHeight
* @param {boolean=} constraintsInDip
- */
- constructor(isVertical, secondIsSidebar, settingName, defaultSidebarWidth, defaultSidebarHeight, constraintsInDip) {
+ * @param {number=} resizerThickness
einbinder 2017/01/04 00:26:26 Adding yet another parameter feels unfortunate.
dgozman 2017/01/04 18:11:22 Turn it into a setter.
+ */
+ constructor(
+ isVertical,
+ secondIsSidebar,
+ settingName,
+ defaultSidebarWidth,
+ defaultSidebarHeight,
+ constraintsInDip,
+ resizerThickness) {
super(true);
this.element.classList.add('split-widget');
this.registerRequiredCSS('ui/splitWidget.css');
@@ -51,6 +59,12 @@ UI.SplitWidget = class extends UI.Widget {
this.contentElement.createChild('div', 'shadow-split-widget-contents shadow-split-widget-sidebar vbox');
this._sidebarElement.createChild('content').select = '.insertion-point-sidebar';
this._resizerElement = this.contentElement.createChild('div', 'shadow-split-widget-resizer');
+ if (typeof resizerThickness === 'number') {
+ if (isVertical)
dgozman 2017/01/04 18:11:22 Note that isVertical may change (see setVertical).
+ this._resizerElement.style.height = resizerThickness + 'px';
+ else
+ this._resizerElement.style.width = resizerThickness + 'px';
dgozman 2017/01/04 18:11:22 This makes it extra-thick in device mode, right?
einbinder 2017/01/05 20:41:00 Done.
+ }
this._resizerWidget = new UI.SimpleResizerWidget();
this._resizerWidget.setEnabled(true);

Powered by Google App Engine
This is Rietveld 408576698