DevTools: Remove left margin when DevTools is docked

third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 19 matching lines @@
  * @unrestricted
  */
 UI.SplitWidget = class extends UI.Widget {
   /**
    * @param {boolean} isVertical
    * @param {boolean} secondIsSidebar
    * @param {string=} settingName
    * @param {number=} defaultSidebarWidth
    * @param {number=} defaultSidebarHeight
    * @param {boolean=} constraintsInDip
+   * @param {number=} resizerThickness

[einbinder, 2017/01/04 00:26:26]

Adding yet another parameter feels unfortunate. 

[dgozman, 2017/01/04 18:11:22]

Turn it into a setter.

    */
-  constructor(isVertical, secondIsSidebar, settingName, defaultSidebarWidth, defaultSidebarHeight, constraintsInDip) {
+  constructor(
+      isVertical,
+      secondIsSidebar,
+      settingName,
+      defaultSidebarWidth,
+      defaultSidebarHeight,
+      constraintsInDip,
+      resizerThickness) {
     super(true);
     this.element.classList.add('split-widget');
     this.registerRequiredCSS('ui/splitWidget.css');
 
     this.contentElement.classList.add('shadow-split-widget');
     this._mainElement =
         this.contentElement.createChild('div', 'shadow-split-widget-contents shadow-split-widget-main vbox');
     this._mainElement.createChild('content').select = '.insertion-point-main';
     this._sidebarElement =
         this.contentElement.createChild('div', 'shadow-split-widget-contents shadow-split-widget-sidebar vbox');
     this._sidebarElement.createChild('content').select = '.insertion-point-sidebar';
     this._resizerElement = this.contentElement.createChild('div', 'shadow-split-widget-resizer');
+    if (typeof resizerThickness === 'number') {
+      if (isVertical)

[dgozman, 2017/01/04 18:11:22]

Note that isVertical may change (see setVertical).

+        this._resizerElement.style.height = resizerThickness + 'px';
+      else
+        this._resizerElement.style.width = resizerThickness + 'px';

[dgozman, 2017/01/04 18:11:22]

This makes it extra-thick in device mode, right?

I'd just craft some css to translate(?) the resizer of one specific split
widget.

[einbinder, 2017/01/05 20:41:00]

Done.

+    }
 
     this._resizerWidget = new UI.SimpleResizerWidget();
     this._resizerWidget.setEnabled(true);
     this._resizerWidget.addEventListener(UI.ResizerWidget.Events.ResizeStart, this._onResizeStart, this);
     this._resizerWidget.addEventListener(UI.ResizerWidget.Events.ResizeUpdate, this._onResizeUpdate, this);
     this._resizerWidget.addEventListener(UI.ResizerWidget.Events.ResizeEnd, this._onResizeEnd, this);
 
     this._defaultSidebarWidth = defaultSidebarWidth || 200;
     this._defaultSidebarHeight = defaultSidebarHeight || this._defaultSidebarWidth;
     this._constraintsInDip = !!constraintsInDip;
@@ skipping 814 matching lines @@
   OnlySidebar: 'OnlySidebar'
 };
 
 /** @enum {symbol} */
 UI.SplitWidget.Events = {
   SidebarSizeChanged: Symbol('SidebarSizeChanged'),
   ShowModeChanged: Symbol('ShowModeChanged')
 };
 
 UI.SplitWidget.MinPadding = 20;