Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 260933005: Prefer MSVS 2013 over MSVS 2010 (Closed)

Created:
6 years, 7 months ago by Shezan Baig (Bloomberg)
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Prefer MSVS 2013 over MSVS 2010 BUG= R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pylib/gyp/MSVSVersion.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Shezan Baig (Bloomberg)
Not sure if I should just sort them all in descending order, but for now ...
6 years, 7 months ago (2014-05-01 18:22:28 UTC) #1
scottmg
lgtm
6 years, 7 months ago (2014-05-01 18:25:17 UTC) #2
Shezan Baig
On 2014/05/01 18:25:17, scottmg wrote: > lgtm I'm running into an issue with the pylint ...
6 years, 7 months ago (2014-05-01 19:51:38 UTC) #3
Shezan Baig (Bloomberg)
6 years, 7 months ago (2014-05-06 16:52:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1916 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698