Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: pkg/shelf/test/log_middleware_test.dart

Issue 260933004: Support Request hijacking in Shelf, using a similar API to Rack. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/shelf/test/hijack_test.dart ('k') | pkg/shelf/test/shelf_io_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/shelf/test/log_middleware_test.dart
diff --git a/pkg/shelf/test/log_middleware_test.dart b/pkg/shelf/test/log_middleware_test.dart
index b9a83044e480da72dfbccea5100aedb9590753eb..e056504d2ad7d48639898d5e9a08a541237012ba 100644
--- a/pkg/shelf/test/log_middleware_test.dart
+++ b/pkg/shelf/test/log_middleware_test.dart
@@ -58,4 +58,14 @@ void main() {
expect(makeSimpleRequest(handler), throwsA('testing logging throw'));
});
+
+ test("doesn't log a HijackException", () {
+ var handler = const Pipeline()
+ .addMiddleware(logRequests(logger: logger))
+ .addHandler((request) => throw const HijackException());
+
+ expect(makeSimpleRequest(handler).whenComplete(() {
+ expect(gotLog, isFalse);
+ }), throwsA(new isInstanceOf<HijackException>()));
+ });
}
« no previous file with comments | « pkg/shelf/test/hijack_test.dart ('k') | pkg/shelf/test/shelf_io_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698