Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2609323003: Report downloaded resources at most once (Closed)

Created:
3 years, 11 months ago by twifkak
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Report downloaded resources at most once Before, we were reporting used_resources and unused_resources. used_resources was reported only once when the resource is used but unused_resources was reported on every single prefetch session for as long as the resource was still unused. This change removes unused_resources and adds downloaded resources (with URL parameter d), which reports the "cost" of a resource once. This allows to have a meaningful ratio of used_resources / downloaded_resources. BUG=675732 Review-Url: https://codereview.chromium.org/2586813004 Cr-Commit-Position: refs/heads/master@{#440176} (cherry picked from commit 02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0) Committed: https://chromium.googlesource.com/chromium/src/+/c85e96f98e7d442b87e219fe0631c92b7c176b54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -95 lines) Patch
M components/precache/core/precache_database.h View 3 chunks +6 lines, -4 lines 0 comments Download
M components/precache/core/precache_database.cc View 6 chunks +17 lines, -9 lines 0 comments Download
M components/precache/core/precache_database_unittest.cc View 8 chunks +66 lines, -19 lines 0 comments Download
M components/precache/core/precache_fetcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/precache/core/precache_fetcher.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 5 chunks +52 lines, -8 lines 0 comments Download
M components/precache/core/precache_url_table.h View 3 chunks +14 lines, -5 lines 0 comments Download
M components/precache/core/precache_url_table.cc View 4 chunks +48 lines, -23 lines 0 comments Download
M components/precache/core/precache_url_table_unittest.cc View 7 chunks +41 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
twifkak
3 years, 11 months ago (2017-01-03 23:45:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c85e96f98e7d442b87e219fe0631c92b7c176b54.

Powered by Google App Engine
This is Rietveld 408576698