Issue 2609313003: python-adb: Quit early when trying to connect to a missing device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2609313003: python-adb: Quit early when trying to connect to a missing device. (Closed)

Created:
3 years, 11 months ago by bpastene

Modified:
3 years, 11 months ago

Reviewers:
KevinL, jbudorick

CC:
chromium-reviews, infra-reviews+build_chromium.org

Target Ref:
refs/heads/master

Visibility:
Public.

python-adb: Quit early when trying to connect to a missing device. The logic here is that if the device doesn't show up, chances are it won't show up for a bit. Best quit early and move on with life instead of sticking around and waiting for it. Tested on -dev. Device reboots seem to work. BUG=670879, 675270 R=jbudorick@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=5d1bc3477b9be2fa74cc6a29fb6731ad0ab70b37

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	adb/contrib/adb_commands_safe.py	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

bpastene

3 years, 11 months ago (2017-01-04 22:43:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5d1bc3477b9be2fa74cc6a29fb6731ad0ab70b37 (presubmit successful).