Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7298)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 2609253003: Remove ForceReclaimResources (Closed)
Patch Set: Fix tests and re-enable previous swap behavior Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 9d01bd653cb692523f0cfccf3bcc9f098ad0f097..cb43af9715c2e3ad4bddcff3f55f5d8f08fda9cc 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -330,15 +330,6 @@ void LayerTreeHostImpl::BeginMainFrameAborted(
void LayerTreeHostImpl::BeginCommit() {
TRACE_EVENT0("cc", "LayerTreeHostImpl::BeginCommit");
- // Ensure all textures are returned so partial texture updates can happen
- // during the commit.
- // TODO(ericrk): We should not need to ForceReclaimResources when using
- // Impl-side-painting as it doesn't upload during commits. However,
- // Display::Draw currently relies on resource being reclaimed to block drawing
- // between BeginCommit / Swap. See crbug.com/489515.
- if (compositor_frame_sink_)
- compositor_frame_sink_->ForceReclaimResources();
-
if (!CommitToActiveTree())
CreatePendingTree();
}
@@ -782,12 +773,12 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(FrameData* frame) {
!root_surface->layer_list().empty();
bool hud_wants_to_draw_ = active_tree_->hud_layer() &&
active_tree_->hud_layer()->IsAnimatingHUDContents();
- bool resources_must_be_resent =
- compositor_frame_sink_->capabilities().can_force_reclaim_resources;
+ bool must_always_swap =
+ compositor_frame_sink_->capabilities().must_always_swap;
if (root_surface_has_contributing_layers &&
root_surface_has_no_visible_damage &&
!active_tree_->property_trees()->effect_tree.HasCopyRequests() &&
- !resources_must_be_resent && !hud_wants_to_draw_) {
+ !must_always_swap && !hud_wants_to_draw_) {
TRACE_EVENT0("cc",
"LayerTreeHostImpl::CalculateRenderPasses::EmptyDamageRect");
frame->has_no_damage = true;

Powered by Google App Engine
This is Rietveld 408576698