Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: runtime/observatory/lib/src/elements/isolate_view.dart

Issue 2609253002: Added isolate + thread high watermark tracking to Observatory (Closed)
Patch Set: Merge branch 'master' of github.com:dart-lang/sdk into resubmit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/isolate_view.dart
diff --git a/runtime/observatory/lib/src/elements/isolate_view.dart b/runtime/observatory/lib/src/elements/isolate_view.dart
index 706de4ccd053a264f56540fcb2e8024e323f8d36..7e7599e58744b5e9bf7e3b1545ded14d781faecf 100644
--- a/runtime/observatory/lib/src/elements/isolate_view.dart
+++ b/runtime/observatory/lib/src/elements/isolate_view.dart
@@ -297,6 +297,19 @@ class IsolateViewElement extends HtmlElement implements Renderable {
..text = 'object store'
]
],
+ new DivElement()
+ ..classes = ['memberItem']
+ ..children = [
+ new DivElement()
+ ..classes = ['memberName']
+ ..text = 'native memory usage high watermark'
+ ..title = '''The maximum amount of native memory allocated
+ by the isolate over it\'s life.''',
+ new DivElement()
+ ..classes = ['memberValue']
+ ..text = Utils.formatSize(_isolate.memoryHighWatermark)
+ ..title = '${_isolate.memoryHighWatermark}B'
+ ],
new BRElement(),
new DivElement()
..classes = ['memberItem']
@@ -363,6 +376,11 @@ class IsolateViewElement extends HtmlElement implements Renderable {
..classes = ['indent']
..text = 'kind ${t.kindString}',
new DivElement()
+ ..classes = ['indent']
+ ..title = '${t.memoryHighWatermark}B'
+ ..text =
+ 'native memory usage high watermark ${Utils.formatSize(t.memoryHighWatermark)}',
+ new DivElement()
..children = t.zones
.map((z) => new DivElement()
..classes = ['indent']
« no previous file with comments | « no previous file | runtime/observatory/lib/src/models/objects/isolate.dart » ('j') | runtime/vm/thread_registry.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698