Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 260923003: Revert of Consolidate all touch/gesture related constants in content (Closed)

Created:
6 years, 7 months ago by jdduke (slow)
Modified:
6 years, 7 months ago
Reviewers:
sadrul, jam, tdresser
CC:
chromium-reviews, darin-cc_chromium.org, tdresser
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Consolidate all touch/gesture related constants in content (https://codereview.chromium.org/235003005/) Reason for revert: Broke content perftest compile, http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/59025 etc... Original issue's description: > Consolidate all touch/gesture related constants in content > > InputRouter, TouchEventQueue and GestureEventQueue all use a variety of > configuration parameters that are littered through the code in a very ad-hoc > and hard-to-follow fashion. Consolidate all such parameters into well-defined > configuration structs, with helper functions to generate the appropriate > parameters per platform. This simplifies testing and eases the mental burden > of tracking down the origin of the various magic constants. > > Note that this change disables scroll gesture debounce by default, enabling it > only for ChromeOS. > > BUG=343917, 353702 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268051 TBR=jam@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+579 lines, -544 lines) Patch
M content/browser/android/content_startup_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue.h View 6 chunks +21 lines, -27 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue.cc View 7 chunks +34 lines, -24 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue_unittest.cc View 15 chunks +40 lines, -11 lines 0 comments Download
D content/browser/renderer_host/input/input_router_config_helper.h View 1 chunk +0 lines, -18 lines 0 comments Download
D content/browser/renderer_host/input/input_router_config_helper.cc View 1 chunk +0 lines, -144 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 3 chunks +7 lines, -11 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 6 chunks +73 lines, -8 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 8 chunks +21 lines, -23 lines 0 comments Download
M content/browser/renderer_host/input/tap_suppression_controller.h View 3 chunks +1 line, -20 lines 0 comments Download
M content/browser/renderer_host/input/tap_suppression_controller.cc View 5 chunks +9 lines, -21 lines 0 comments Download
M content/browser/renderer_host/input/tap_suppression_controller_client.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/tap_suppression_controller_unittest.cc View 16 chunks +51 lines, -50 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 4 chunks +11 lines, -28 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 13 chunks +62 lines, -72 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 4 chunks +15 lines, -22 lines 0 comments Download
M content/browser/renderer_host/input/touchpad_tap_suppression_controller.h View 4 chunks +6 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/touchpad_tap_suppression_controller.cc View 1 chunk +21 lines, -18 lines 0 comments Download
A content/browser/renderer_host/input/touchpad_tap_suppression_controller_aura.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/touchscreen_tap_suppression_controller.cc View 2 chunks +34 lines, -7 lines 0 comments Download
A content/browser/renderer_host/input/touchscreen_tap_suppression_controller_stub.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 15 chunks +28 lines, -22 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +16 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jdduke (slow)
Created Revert of Consolidate all touch/gesture related constants in content
6 years, 7 months ago (2014-05-03 05:56:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/260923003/1
6 years, 7 months ago (2014-05-03 05:57:16 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-03 05:57:17 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-03 05:57:17 UTC) #4
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 7 months ago (2014-05-03 05:58:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/260923003/1
6 years, 7 months ago (2014-05-03 06:01:48 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 06:08:26 UTC) #7
Message was sent while issue was closed.
Change committed as 268052

Powered by Google App Engine
This is Rietveld 408576698