Maintain referential integrity of proxy instances in dart:js

sdk/lib/js/dart2js/js_dart2js.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart.js;
 
 import 'dart:_foreign_helper' show JS;
 import 'dart:_js_helper' show Primitives, convertDartClosureToJS;
 
 final JsObject context = new JsObject._fromJs(Primitives.computeGlobalThis());
@@ skipping 148 matching lines @@
   apply(thisArg, [List args]) =>
       _convertToDart(JS('=Object', '#.apply(#, #)', _convertToJS(this),
           _convertToJS(thisArg),
           args == null ? null : args.map(_convertToJS).toList()));
 }
 
 abstract class Serializable<T> {
   T toJs();
 }
 
+// property added to a Dart object referencing its JS-side DartObject proxy
+const _DART_OBJECT_PROPERTY_NAME = r'_$dart_dartObject';
+const _DART_CLOSURE_PROPERTY_NAME = r'_$dart_dartClosure';
+
+// property added to a JS object referencing its Dart-side JsObject proxy
+const _JS_OBJECT_PROPERTY_NAME = r'_$dart_jsObject';
+const _JS_FUNCTION_PROPERTY_NAME = r'$dart_jsFunction';
+
 dynamic _convertToJS(dynamic o) {
   if (o == null) {
     return null;
   } else if (o is String || o is num || o is bool) {
     return o;
   } else if (o is JsObject) {
     return o._jsObject;
   } else if (o is Serializable) {
     return _convertToJS(o.toJs());
   } else if (o is Function) {
     return _convertToJS(new Callback(o));
   } else {
-    return JS('=Object', 'new DartProxy(#)', o);
+    return JS('=Object', 'new DartObject(#)', o);
   }
 }
 
+// converts a Dart object to a reference to a native JS object
+// which might be a DartObject JS->Dart proxy
 dynamic _convertToDart(dynamic o) {
   if (JS('bool', '# == null', o)) {
     return null;
   } else if (JS('bool', 'typeof # == "string" || # instanceof String', o, o) ||
       JS('bool', 'typeof # == "number" || # instanceof Number', o, o) ||
       JS('bool', 'typeof # == "boolean" || # instanceof Boolean', o, o)) {
     return o;
   } else if (JS('bool', '# instanceof Function', o)) {
-    return new JsFunction._fromJs(JS('=Object', '#', o));
-  } else if (JS('bool', '# instanceof DartProxy', o)) {
+    return _getDartProxy(o, _DART_CLOSURE_PROPERTY_NAME,
+        (o) => JsFunction._fromJs(o));

[alexandre.ardhuin, 2013/10/07 19:41:30]

"new" is missing.

[justinfagnani, 2013/10/07 20:17:51]

Done.

+  } else if (JS('bool', '# instanceof DartObject', o)) {
     return JS('var', '#.o', o);
   } else {
-    return new JsObject._fromJs(JS('=Object', '#', o));
+    return _getDartProxy(o, _DART_OBJECT_PROPERTY_NAME,
+        (o) => JsObject._fromJs(o));

[alexandre.ardhuin, 2013/10/07 19:41:30]

"new" is missing.

[justinfagnani, 2013/10/07 20:17:51]

Done.

   }
-}
+}
+
+dynamic _getDartProxy(o, String propertyName, createProxy(o)) {
+    var dartProxy = JS('', '#[#]', o, propertyName);

[alexandre.ardhuin, 2013/10/07 19:41:30]

Indentation size.

[justinfagnani, 2013/10/07 20:17:51]

Done.

+    if (dartProxy == null) {
+      dartProxy = createProxy(JS('=Object', '#', o));
+      JS('void', 'Object.defineProperty(#, #, { value: #})', o, propertyName,
+          dartProxy);
+    }
+    return dartProxy;
+}