Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2609053002: Revert of Change Share Extension string for consistency (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 11 months ago
Reviewers:
Olivier
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change Share Extension string for consistency (patchset #1 id:1 of https://codereview.chromium.org/2574263002/ ) Reason for revert: Wrong string. Original issue's description: > Change Share Extension string for consistency > > This CL changes the Share Extension string from "Add to Reading List" to > "Read Later" in order to be consistent with the other usages. > > BUG=673689 > > Committed: https://crrev.com/dca2d3d13407eafe6d60103a8dff9e7dfd408926 > Cr-Commit-Position: refs/heads/master@{#439443} TBR=olivierrobin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=673689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/share_extension/strings/ios_share_extension_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
gambard
Created Revert of Change Share Extension string for consistency
3 years, 11 months ago (2017-01-02 15:03:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609053002/1
3 years, 11 months ago (2017-01-02 15:04:06 UTC) #3
Olivier
3 years, 11 months ago (2017-01-05 07:51:50 UTC) #5
On 2017/01/02 15:04:06, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Closing after discussion with UX.

Powered by Google App Engine
This is Rietveld 408576698