Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 260903024: Temporarily disable VirtualKeyboardBrowserTest.IsKeyboardLoaded to land the V8 roll. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Temporarily disable VirtualKeyboardBrowserTest.IsKeyboardLoaded to land the V8 roll. The current v8 roll breaks this test due to the activation of Object.observe. BUG=370004 TBR=ishell@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268173

Patch Set 1 #

Patch Set 2 : Add bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
PTAL - one possibility - but I am not happy about it. TODO: Add a ...
6 years, 7 months ago (2014-05-05 13:36:17 UTC) #1
Michael Achenbach
Will disable the test to get canary coverage for Object.observe. Will revert object observe if ...
6 years, 7 months ago (2014-05-05 13:57:51 UTC) #2
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 7 months ago (2014-05-05 13:57:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/260903024/20001
6 years, 7 months ago (2014-05-05 13:58:03 UTC) #4
commit-bot: I haz the power
Change committed as 268173
6 years, 7 months ago (2014-05-05 13:58:59 UTC) #5
Igor Sheludko
6 years, 7 months ago (2014-05-05 14:11:58 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698