Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 260903020: Remove WebWidget::ForceSoftwareRenderingAndIgnoreGPUResidentContent. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, enne (OOO), ojan
Visibility:
Public.

Description

Remove WebWidget::ForceSoftwareRenderingAndIgnoreGPUResidentContent. Since the widget is composited, call paintCompositedDeprecated() which does what ForceSoftwareRenderingAndIgnoreGPUResidentContent did. Depends on: https://codereview.chromium.org/269723008/ R=piman, trchen BUG=251960 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268370

Patch Set 1 #

Patch Set 2 : webwidget-software-android: #

Patch Set 3 : webwidget-software-android: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/renderer/render_view_impl.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
danakj
6 years, 7 months ago (2014-05-02 22:28:10 UTC) #1
piman
lgtm
6 years, 7 months ago (2014-05-02 22:36:42 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-02 22:37:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/260903020/1
6 years, 7 months ago (2014-05-02 22:38:14 UTC) #4
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 7 months ago (2014-05-02 23:11:28 UTC) #5
danakj
PTAL. Is this webwidget_ always composited?
6 years, 7 months ago (2014-05-02 23:29:55 UTC) #6
danakj
(This now depends on https://codereview.chromium.org/269723008/)
6 years, 7 months ago (2014-05-02 23:30:15 UTC) #7
aelias_OOO_until_Jul13
Yes, it's always composited. You can replace the if with a DCHECK.
6 years, 7 months ago (2014-05-02 23:33:27 UTC) #8
danakj
Thanks, done. PTAL alex
6 years, 7 months ago (2014-05-02 23:46:46 UTC) #9
aelias_OOO_until_Jul13
lgtm
6 years, 7 months ago (2014-05-02 23:56:21 UTC) #10
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-05 22:07:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/260903020/30001
6 years, 7 months ago (2014-05-05 22:07:26 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 01:54:20 UTC) #13
Message was sent while issue was closed.
Change committed as 268370

Powered by Google App Engine
This is Rietveld 408576698