Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260903019: Dump raw tracing data when smoothness_controlller fails to issue timeline marker. (Closed)

Created:
6 years, 7 months ago by nednguyen
Modified:
6 years, 7 months ago
Reviewers:
Dominik Grewe, tonyg, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Dump raw tracing data when smoothness_controlller fails to issue timeline marker. BUG=369461 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267968

Patch Set 1 #

Total comments: 1

Patch Set 2 : change fails -> failed in debugging message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M tools/perf/measurements/smoothness_controller.py View 1 4 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
nednguyen
6 years, 7 months ago (2014-05-02 20:00:37 UTC) #1
nednguyen
6 years, 7 months ago (2014-05-02 20:01:03 UTC) #2
nduca
lgtm https://codereview.chromium.org/260903019/diff/1/tools/perf/measurements/smoothness_controller.py File tools/perf/measurements/smoothness_controller.py (right): https://codereview.chromium.org/260903019/diff/1/tools/perf/measurements/smoothness_controller.py#newcode79 tools/perf/measurements/smoothness_controller.py:79: raise Exception('SmoothnessController fails to issue markers for the ...
6 years, 7 months ago (2014-05-02 20:05:33 UTC) #3
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-05-02 20:07:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/260903019/20001
6 years, 7 months ago (2014-05-02 20:07:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:28:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:28:30 UTC) #7
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-05-02 20:46:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/260903019/20001
6 years, 7 months ago (2014-05-02 20:46:32 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 21:04:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 21:04:15 UTC) #11
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-05-02 21:22:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/260903019/20001
6 years, 7 months ago (2014-05-02 21:23:11 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 21:25:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 21:25:35 UTC) #15
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-05-02 21:33:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/260903019/20001
6 years, 7 months ago (2014-05-02 21:33:26 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 23:34:52 UTC) #18
Message was sent while issue was closed. 
Change committed as 267968

Powered by Google App Engine
This is Rietveld 408576698