Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260903011: Renamed namespaces of url lib and removed namespace aliases. (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Renamed namespaces of url lib and removed namespace aliases. url_util -> url url_parse -> url url_canon -> url BUG=364747 TBR=estade Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267681

Patch Set 1 : Thu 05/01/2014 11:38:37.95 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M components/autofill/content/browser/wallet/wallet_service_url.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M net/base/filename_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/gurl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/third_party/mozilla/url_parse.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_export.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webkit/common/database/database_identifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-05-01 18:41:03 UTC) #1
michaeln
webkit/common lgtm
6 years, 7 months ago (2014-05-01 18:52:29 UTC) #2
willchan no longer on Chromium
net/ lgtm
6 years, 7 months ago (2014-05-01 19:07:53 UTC) #3
brettw
lgtm
6 years, 7 months ago (2014-05-01 19:12:20 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-01 20:19:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/260903011/40001
6 years, 7 months ago (2014-05-01 20:19:21 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 21:34:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 21:34:34 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-01 21:36:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/260903011/40001
6 years, 7 months ago (2014-05-01 21:36:45 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 00:02:26 UTC) #11
Message was sent while issue was closed. 
Change committed as 267681

Powered by Google App Engine
This is Rietveld 408576698