|
|
Created:
6 years, 7 months ago by borenet Modified:
6 years, 7 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
Descriptionsafely-roll-deps: print every command
BUG=363147
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268239
Patch Set 1 #
Total comments: 2
Patch Set 2 : sys.stdout.flush #Messages
Total messages: 17 (0 generated)
If we're going to do this, timestamps/runtimes might be nice.
lgtm, but I don't think I have power here.
On 2014/05/01 18:26:37, eseidel wrote: > lgtm, but I don't think I have power here. Ping @maruel
lgtm but this is quite drastic. In general a wrapper function is less aggressive. https://codereview.chromium.org/260903009/diff/1/tools/safely-roll-deps.py File tools/safely-roll-deps.py (right): https://codereview.chromium.org/260903009/diff/1/tools/safely-roll-deps.py#ne... tools/safely-roll-deps.py:52: print cmd you'll want to sys.stdout.flush()
Uploaded patch set 2. I guess it's a little aggressive, but it seemed nicer than writing a wrapper function for every subprocess2 function we call... https://codereview.chromium.org/260903009/diff/1/tools/safely-roll-deps.py File tools/safely-roll-deps.py (right): https://codereview.chromium.org/260903009/diff/1/tools/safely-roll-deps.py#ne... tools/safely-roll-deps.py:52: print cmd On 2014/05/02 16:34:41, M-A Ruel wrote: > you'll want to sys.stdout.flush() Done.
The CQ bit was checked by borenet@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/260903009/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
The CQ bit was checked by borenet@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/260903009/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
The CQ bit was checked by eseidel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/260903009/20001
Message was sent while issue was closed.
Change committed as 268239 |