Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 260903009: safely-roll-deps: print every command (Closed)

Created:
6 years, 7 months ago by borenet
Modified:
6 years, 7 months ago
Reviewers:
M-A Ruel, eseidel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

safely-roll-deps: print every command BUG=363147 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268239

Patch Set 1 #

Total comments: 2

Patch Set 2 : sys.stdout.flush #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M tools/safely-roll-deps.py View 1 5 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
borenet
6 years, 7 months ago (2014-05-01 17:52:21 UTC) #1
eseidel
If we're going to do this, timestamps/runtimes might be nice.
6 years, 7 months ago (2014-05-01 18:26:27 UTC) #2
eseidel
lgtm, but I don't think I have power here.
6 years, 7 months ago (2014-05-01 18:26:37 UTC) #3
borenet
On 2014/05/01 18:26:37, eseidel wrote: > lgtm, but I don't think I have power here. ...
6 years, 7 months ago (2014-05-02 15:47:19 UTC) #4
M-A Ruel
lgtm but this is quite drastic. In general a wrapper function is less aggressive. https://codereview.chromium.org/260903009/diff/1/tools/safely-roll-deps.py ...
6 years, 7 months ago (2014-05-02 16:34:41 UTC) #5
borenet
Uploaded patch set 2. I guess it's a little aggressive, but it seemed nicer than ...
6 years, 7 months ago (2014-05-02 19:51:15 UTC) #6
borenet
The CQ bit was checked by borenet@google.com
6 years, 7 months ago (2014-05-02 19:51:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/260903009/20001
6 years, 7 months ago (2014-05-02 19:52:36 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:10:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:10:44 UTC) #10
borenet
The CQ bit was checked by borenet@google.com
6 years, 7 months ago (2014-05-02 20:11:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/260903009/20001
6 years, 7 months ago (2014-05-02 20:11:43 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:26:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:26:30 UTC) #14
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 7 months ago (2014-05-05 15:22:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/260903009/20001
6 years, 7 months ago (2014-05-05 15:22:09 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 19:07:13 UTC) #17
Message was sent while issue was closed.
Change committed as 268239

Powered by Google App Engine
This is Rietveld 408576698