Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java

Issue 260903006: Dismissing of date/time dialogs should not set the value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java b/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java
index ea699f1dffd0f5457941e42838feda3f2698b863..c52090b757ee516ec065394d3704bca97c2e699d 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java
@@ -8,7 +8,6 @@ import android.app.AlertDialog;
import android.content.Context;
import android.content.DialogInterface;
import android.content.DialogInterface.OnClickListener;
-import android.os.Build;
import android.text.format.Time;
import android.view.LayoutInflater;
import android.view.View;
@@ -107,18 +106,6 @@ class DateTimePickerDialog extends AlertDialog implements OnClickListener,
}
@Override
- protected void onStop() {
- if (Build.VERSION.SDK_INT >= 16) {
- // The default behavior of dialogs changed in JellyBean and onwards.
- // Dismissing a dialog (by pressing back for example)
- // applies the chosen date. This code is added here so that the custom
- // pickers behave the same as the internal DatePickerDialog.
- tryNotifyDateTimeSet();
- }
- super.onStop();
- }
-
- @Override
public void onDateChanged(DatePicker view, int year,
int month, int day) {
// Signal a time change so the max/min checks can be applied.

Powered by Google App Engine
This is Rietveld 408576698