Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 260903003: Enable "unreachable code" warning for MSVC. (Closed)

Created:
6 years, 7 months ago by Peter Kasting
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Enable "unreachable code" warning for MSVC. BUG=346399 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272687

Patch Set 1 #

Patch Set 2 : Leave 4702 disabled for VC Express #

Total comments: 2

Patch Set 3 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M build/common.gypi View 1 2 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Kasting
6 years, 7 months ago (2014-05-22 23:34:29 UTC) #1
scottmg
lgtm https://codereview.chromium.org/260903003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/260903003/diff/20001/build/common.gypi#newcode4920 build/common.gypi:4920: # to VS2013 Update 2. Please add crbug/what ...
6 years, 7 months ago (2014-05-22 23:39:06 UTC) #2
Peter Kasting
https://codereview.chromium.org/260903003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/260903003/diff/20001/build/common.gypi#newcode4920 build/common.gypi:4920: # to VS2013 Update 2. On 2014/05/22 23:39:06, scottmg ...
6 years, 7 months ago (2014-05-23 17:51:16 UTC) #3
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 7 months ago (2014-05-23 17:51:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/260903003/40001
6 years, 7 months ago (2014-05-23 17:52:46 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 22:36:18 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 02:35:30 UTC) #7
Message was sent while issue was closed.
Change committed as 272687

Powered by Google App Engine
This is Rietveld 408576698