Issue 260893013: JSON Schema Compiler: Following r267534, properly convert arrays of enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 260893013: JSON Schema Compiler: Following r267534, properly convert arrays of enums (Closed)

Created:
6 years, 7 months ago by not at google - send to devlin

Modified:
6 years, 7 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, armansito

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

JSON Schema Compiler: Following r267534, properly convert arrays of enums within types. BUG=368368 R=yoz@chromium.org

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -13 lines)			Patch
M	tools/json_schema_compiler/cc_generator.py	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download
M	tools/json_schema_compiler/util.h	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	tools/json_schema_compiler/util_cc_helper.py	View	1	1 chunk	+23 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

not at google - send to devlin

my bad I didn't send it out. I found another very subtle bug and haven't ...

6 years, 7 months ago (2014-05-06 18:09:54 UTC) #2

Yoyo Zhou

6 years, 7 months ago (2014-05-06 18:21:21 UTC) #3

woops! I didn't notice that; just saw it in my list of reviews.