Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: ios/chrome/share_extension/strings/ios_share_extension_strings.grd

Issue 2608913002: Handle invalid URLs in share extension. (Closed)
Patch Set: test local additions Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/share_extension/strings/ios_share_extension_strings.grd
diff --git a/ios/chrome/share_extension/strings/ios_share_extension_strings.grd b/ios/chrome/share_extension/strings/ios_share_extension_strings.grd
index 5a9aeae74049918452bf1e42c583f87e5c471801..30058e59a30b66201a70fca1b196eae88af0b874 100644
--- a/ios/chrome/share_extension/strings/ios_share_extension_strings.grd
+++ b/ios/chrome/share_extension/strings/ios_share_extension_strings.grd
@@ -136,6 +136,12 @@ all other OS specific variables will be false.
<message name="IDS_IOS_ADD_BOOKMARKS_SHARE_EXTENSION" desc="Share extension button to add to bookmarks [Length: 30em]" meaning="Button title [Length: 30em]">
Add to Bookmarks
</message>
+ <message name="IDS_IOS_ERROR_MESSAGE_SHARE_EXTENSION" desc="Share extension message to telle the user the URL cannot be processed. The name of the application will be put in place of APPLICATION_NAME">
gambard 2017/01/02 09:11:41 s/telle/tell.
Olivier 2017/01/02 10:40:40 Done.
+ APPLICATION_NAME cannot handle this link.
gambard 2017/01/02 09:11:41 Aren't we using placeholder for that kind of thing
Olivier 2017/01/02 10:40:40 placeholder handling is in ios/chrome/common which
gambard 2017/01/02 10:55:08 Acknowledged.
+ </message>
+ <message name="IDS_IOS_OK_BUTTON_SHARE_EXTENSION" desc="Label for the OK button in the share extension.">
+ OK
+ </message>
</messages>
</release>
</grit>

Powered by Google App Engine
This is Rietveld 408576698