ios/chrome/browser/share_extension/share_extension_item_receiver.mm - Issue 2608913002: Handle invalid URLs in share extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/share_extension/share_extension_item_receiver.mm

Issue 2608913002: Handle invalid URLs in share extension. (Closed)

Patch Set: adding gambard as OWNER Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/share_extension/OWNERS ('k') | ios/chrome/share_extension/share_extension_localize_strings_config.plist » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/share_extension/share_extension_item_receiver.mm

diff --git a/ios/chrome/browser/share_extension/share_extension_item_receiver.mm b/ios/chrome/browser/share_extension/share_extension_item_receiver.mm

index 58da1e248157e35b9f91f36ee9cf5343c0ecd2de..3b615ec23c37b6dd86b6723ad27b88b6d409669e 100644

--- a/ios/chrome/browser/share_extension/share_extension_item_receiver.mm

+++ b/ios/chrome/browser/share_extension/share_extension_item_receiver.mm

@@ -189,7 +189,8 @@ void LogHistogramReceivedItem(ShareExtensionItemReceived type) {

NSNumber* entryType = base::mac::ObjCCast<NSNumber>(

[entry objectForKey:app_group::kShareItemType]);

- if (!entryURL.is_valid() || !entryDate || !entryType) {

+ if (!entryURL.is_valid() || !entryDate || !entryType ||

+ !entryURL.SchemeIsHTTPOrHTTPS()) {

if (completion) {

completion();

}