components/reading_list/ios/reading_list_model_impl.cc - Issue 2608913002: Handle invalid URLs in share extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/reading_list/ios/reading_list_model_impl.cc

Issue 2608913002: Handle invalid URLs in share extension. (Closed)

Patch Set: adding gambard as OWNER Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/reading_list/ios/reading_list_model_impl.cc

diff --git a/components/reading_list/ios/reading_list_model_impl.cc b/components/reading_list/ios/reading_list_model_impl.cc

index fef295916b7f5c7d9a8387435f5f2c61205f756c..fa3a9bc2d126b5f78bc7b2bc5b0503efeff6e0de 100644

--- a/components/reading_list/ios/reading_list_model_impl.cc

+++ b/components/reading_list/ios/reading_list_model_impl.cc

@@ -292,6 +292,7 @@ const ReadingListEntry& ReadingListModelImpl::AddEntry(

const std::string& title) {

DCHECK(CalledOnValidThread());

DCHECK(loaded());

+ DCHECK(url.SchemeIsHTTPOrHTTPS());

RemoveEntryByURL(url);

std::string trimmedTitle(title);

« no previous file with comments | « no previous file | ios/chrome/browser/share_extension/OWNERS » ('j') | no next file with comments »