Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(488)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: ios/chrome/browser/share_extension/OWNERS
Issue
2608913002
:
Handle invalid URLs in share extension. (Closed)
Patch Set: feedback
Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
components/reading_list/ios/reading_list_model_impl.cc
ios/chrome/browser/share_extension/OWNERS
ios/chrome/browser/share_extension/share_extension_item_receiver.mm
ios/chrome/share_extension/share_extension_localize_strings_config.plist
ios/chrome/share_extension/share_extension_view.mm
ios/chrome/share_extension/share_view_controller.mm
ios/chrome/share_extension/strings/ios_share_extension_strings.grd
View unified diff
|
Download patch
« no previous file with comments
|
« components/reading_list/ios/reading_list_model_impl.cc
('k') |
ios/chrome/browser/share_extension/share_extension_item_receiver.mm »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
olivierrobin@chromium.org
noyau (Ping after 24h)
2017/01/02 12:51:28
Needs two owners, both chrome committers.
Needs two owners, both chrome committers.
Olivier
2017/01/02 12:53:50
Done.
Show quoted text
On 2017/01/02 12:51:28, noyau (OOO until Jan 2) wrote: > Needs two owners, both chrome committers.
Done.
OLD
NEW
« no previous file with comments
|
« components/reading_list/ios/reading_list_model_impl.cc
('k') |
ios/chrome/browser/share_extension/share_extension_item_receiver.mm »
('j') |
no next file with comments »
Issue 2608913002: Handle invalid URLs in share extension. (Closed)
Created 3 years, 11 months ago by Olivier
Modified 3 years, 11 months ago
Reviewers: gambard, noyau (Ping after 24h)
Base URL:
Comments: 19
This is Rietveld
408576698