Handle invalid URLs in share extension.

ios/chrome/share_extension/share_extension_view.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/share_extension/share_extension_view.h"
 
 #include "base/logging.h"
 #import "ios/chrome/share_extension/ui_util.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
@@ skipping 39 matching lines @@
 #pragma mark - Share Extension View
 
 @interface ShareExtensionView () {
   __weak id<ShareExtensionViewActionTarget> _target;
 }
 
 // Keep strong references of the views that need to be updated.
 @property(nonatomic, strong) UILabel* titleLabel;
 @property(nonatomic, strong) UILabel* URLLabel;
 @property(nonatomic, strong) UIImageView* screenshotView;
+@property(nonatomic, strong) UIStackView* itemStack;
 
 // View creation helpers.
 // Returns a view containing the shared items (title, URL, screenshot). This
 // method will set the ivars.
 - (UIView*)sharedItemView;
 
 // Returns a button containing the with title |title| and action |selector| on
 // |_target|.
 - (UIButton*)buttonWithTitle:(NSString*)title selector:(SEL)selector;
 
 // Returns a view containing a divider with vibrancy effect.
 - (UIView*)dividerViewWithVibrancy:(UIVisualEffect*)vibrancyEffect;
 
 // Returns a navigationBar.
 - (UINavigationBar*)navigationBar;
 
 @end
 
 @implementation ShareExtensionView
 
 @synthesize titleLabel = _titleLabel;
 @synthesize URLLabel = _URLLabel;
 @synthesize screenshotView = _screenshotView;
+@synthesize itemStack = _itemStack;
 
 #pragma mark - Lifecycle
 
 - (instancetype)initWithActionTarget:
     (id<ShareExtensionViewActionTarget>)target {
   self = [super initWithFrame:CGRectZero];
   if (self) {
     DCHECK(target);
     _target = target;
 
@@ skipping 61 matching lines @@
   [_URLLabel setNumberOfLines:3];
   [_URLLabel setLineBreakMode:NSLineBreakByWordWrapping];
   [_URLLabel setFont:[UIFont systemFontOfSize:12]];
 
   // Screenshot view. Image will be filled by |setScreenshot:| when available.
   _screenshotView = [[UIImageView alloc] initWithFrame:CGRectZero];
   [_screenshotView.widthAnchor
       constraintLessThanOrEqualToConstant:kScreenshotSize]
       .active = YES;
   [_screenshotView.heightAnchor
-      constraintLessThanOrEqualToConstant:kScreenshotSize]
+      constraintEqualToAnchor:_screenshotView.widthAnchor]
       .active = YES;
   [_screenshotView setContentMode:UIViewContentModeScaleAspectFill];
+  [_screenshotView setClipsToBounds:YES];
   [_screenshotView setHidden:YES];
 
   // |_screenshotView| should take as much space as needed. Lower compression
   // resistance of the other elements.
   [_titleLabel
       setContentCompressionResistancePriority:UILayoutPriorityDefaultLow
                                       forAxis:UILayoutConstraintAxisHorizontal];
   [_titleLabel setContentHuggingPriority:UILayoutPriorityDefaultHigh
                                  forAxis:UILayoutConstraintAxisVertical];
   [_URLLabel setContentHuggingPriority:UILayoutPriorityDefaultHigh
@@ skipping 21 matching lines @@
 
   [titleURLStack.centerYAnchor
       constraintEqualToAnchor:titleURLContainer.centerYAnchor]
       .active = YES;
   [titleURLStack.centerXAnchor
       constraintEqualToAnchor:titleURLContainer.centerXAnchor]
       .active = YES;
   [titleURLStack.widthAnchor
       constraintEqualToAnchor:titleURLContainer.widthAnchor]
       .active = YES;
+  [titleURLStack
+      setContentCompressionResistancePriority:UILayoutPriorityDefaultHigh
+                                      forAxis:UILayoutConstraintAxisVertical];
 
-  UIStackView* itemStack = [[UIStackView alloc]
-      initWithArrangedSubviews:@[ titleURLContainer, _screenshotView ]];
-  [itemStack setAxis:UILayoutConstraintAxisHorizontal];
-  [itemStack setLayoutMargins:UIEdgeInsetsMake(kShareExtensionPadding,
-                                               kShareExtensionPadding,
-                                               kShareExtensionPadding,
-                                               kShareExtensionPadding)];
-  [itemStack setLayoutMarginsRelativeArrangement:YES];
-  [itemStack setSpacing:kShareExtensionPadding];
+  _itemStack =
+      [[UIStackView alloc] initWithArrangedSubviews:@[ titleURLContainer ]];
+  [_itemStack setAxis:UILayoutConstraintAxisHorizontal];
+  [_itemStack setLayoutMargins:UIEdgeInsetsMake(kShareExtensionPadding,
+                                                kShareExtensionPadding,
+                                                kShareExtensionPadding,
+                                                kShareExtensionPadding)];
+  [_itemStack setLayoutMarginsRelativeArrangement:YES];
+  [_itemStack setSpacing:kShareExtensionPadding];
 
   [_titleLabel setTranslatesAutoresizingMaskIntoConstraints:NO];
   [_URLLabel setTranslatesAutoresizingMaskIntoConstraints:NO];
   [_screenshotView setTranslatesAutoresizingMaskIntoConstraints:NO];
   [titleURLStack setTranslatesAutoresizingMaskIntoConstraints:NO];
-  [itemStack setTranslatesAutoresizingMaskIntoConstraints:NO];
+  [_itemStack setTranslatesAutoresizingMaskIntoConstraints:NO];
 
-  return itemStack;
+  return _itemStack;
 }
 
 - (UIView*)dividerViewWithVibrancy:(UIVisualEffect*)vibrancyEffect {
   UIVisualEffectView* dividerVibrancy =
       [[UIVisualEffectView alloc] initWithEffect:vibrancyEffect];
   UIView* divider = [[UIView alloc] initWithFrame:CGRectZero];
   [divider setBackgroundColor:[UIColor colorWithWhite:0 alpha:kLowAlpha]];
   [[dividerVibrancy contentView] addSubview:divider];
   [dividerVibrancy setTranslatesAutoresizingMaskIntoConstraints:NO];
   [divider setTranslatesAutoresizingMaskIntoConstraints:NO];
@@ skipping 59 matching lines @@
   [[self URLLabel] setText:[URL absoluteString]];
 }
 
 - (void)setTitle:(NSString*)title {
   [[self titleLabel] setText:title];
 }
 
 - (void)setScreenshot:(UIImage*)screenshot {
   [[self screenshotView] setHidden:NO];
   [[self screenshotView] setImage:screenshot];
+  [[self itemStack] addArrangedSubview:[self screenshotView]];
 }
 
 @end