Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: test/cctest/test-code-stub-assembler.cc

Issue 2608893002: [builtins] Move LoadGlobalICStub to builtins (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-code-stub-assembler.cc
diff --git a/test/cctest/test-code-stub-assembler.cc b/test/cctest/test-code-stub-assembler.cc
index eee46ab2c820fc9e58b2de169e955167d40f370a..8b5a8b965d9631acb80fd7d65e2324fc1dc3b9f0 100644
--- a/test/cctest/test-code-stub-assembler.cc
+++ b/test/cctest/test-code-stub-assembler.cc
@@ -1760,32 +1760,6 @@ void Recompile(Args... args) {
} // namespace
-TEST(CodeStubAssemblerGraphsCorrectness) {
- // The test does not work with interpreter because bytecode handlers taken
- // from the snapshot already refer to precompiled stubs from the snapshot
- // and there is no way to trigger bytecode handlers recompilation.
- if (FLAG_ignition || FLAG_turbo) return;
-
- v8::Isolate::CreateParams create_params;
- create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
- v8::Isolate* v8_isolate = v8::Isolate::New(create_params);
- Isolate* isolate = reinterpret_cast<Isolate*>(v8_isolate);
-
- {
- v8::Isolate::Scope isolate_scope(v8_isolate);
- LocalContext env(v8_isolate);
- v8::HandleScope scope(v8_isolate);
-
- FLAG_csa_verify = true;
-
- // Recompile some stubs here.
- Recompile<LoadGlobalICStub>(isolate, LoadGlobalICState(NOT_INSIDE_TYPEOF));
- Recompile<LoadGlobalICTrampolineStub>(isolate,
- LoadGlobalICState(NOT_INSIDE_TYPEOF));
- }
- v8_isolate->Dispose();
-}
-
void CustomPromiseHook(v8::PromiseHookType type, v8::Local<v8::Promise> promise,
v8::Local<v8::Value> parentPromise) {}
« no previous file with comments | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698