Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: appengine/findit/model/flake/test/master_flake_analysis_test.py

Issue 2608853002: [Findit] Adding suspected CL to master flake analysis in preparation for try jobs (Closed)
Patch Set: 2016 -> 2017 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/flake/test/master_flake_analysis_test.py
diff --git a/appengine/findit/model/flake/test/master_flake_analysis_test.py b/appengine/findit/model/flake/test/master_flake_analysis_test.py
index fcdace3bb54887aba7b653c4e81579031e68b6f6..f53f8dd98bd7c43cc0ebaa288fc62600f4780a48 100644
--- a/appengine/findit/model/flake/test/master_flake_analysis_test.py
+++ b/appengine/findit/model/flake/test/master_flake_analysis_test.py
@@ -3,12 +3,12 @@
# found in the LICENSE file.
from datetime import datetime
-
import unittest
from model import analysis_status
from model import result_status
from model import triage_status
+from model.flake.flake_culprit import FlakeCulprit
from model.flake.master_flake_analysis import DataPoint
from model.flake.master_flake_analysis import MasterFlakeAnalysis
@@ -109,6 +109,8 @@ class MasterFlakeAnalysisTest(unittest.TestCase):
analysis.correct_culprit = None
analysis.data_points = [DataPoint()]
analysis.suspected_flake_build_number = 123
+ analysis.culprit = FlakeCulprit.Create('r', 'a1b2c3d4', 12345, 'url')
+ analysis.try_job_status = analysis_status.COMPLETED
analysis.Reset()
self.assertEqual([], analysis.swarming_rerun_results)
@@ -117,6 +119,8 @@ class MasterFlakeAnalysisTest(unittest.TestCase):
self.assertIsNone(analysis.correct_culprit)
self.assertIsNone(analysis.suspected_flake_build_number)
self.assertEqual([], analysis.data_points)
+ self.assertIsNone(analysis.culprit)
+ self.assertIsNone(analysis.try_job_status)
def testGetErrorMessage(self):
cases = [
@@ -154,3 +158,34 @@ class MasterFlakeAnalysisTest(unittest.TestCase):
self.assertEqual(
(master_name, builder_name),
MasterFlakeAnalysis.GetBuildConfigurationFromKey(key))
+
+ def testGetSuspectedFlakeDataPointNoSuspectedFlakeBuildNumber(self):
+ analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+ self.assertIsNone(analysis.GetSuspectedFlakeDataPoint())
+
+ def testGetSuspectedFlakeDataPoint(self):
+ expected_build_number = 123
+ data_point = DataPoint()
+ data_point.build_number = expected_build_number
+
+ analysis = MasterFlakeAnalysis.Create('m', 'b', 125, 's', 't')
+ analysis.suspected_flake_build_number = expected_build_number
+ analysis.data_points.append(data_point)
+
+ suspected_data_point = analysis.GetSuspectedFlakeDataPoint()
+ self.assertEqual(expected_build_number, suspected_data_point.build_number)
+
+ def testGetSuspectedFlakeDataPointNoDatapoint(self):
+ # This scenario should not happen.
+ expected_build_number = 123
+ unexpected_build_number = 124
+ data_point = DataPoint()
+ data_point.build_number = expected_build_number
+
+ analysis = MasterFlakeAnalysis.Create('m', 'b', 125, 's', 't')
+ analysis.suspected_flake_build_number = unexpected_build_number
+ analysis.data_points.append(data_point)
+
+ self.assertIsNone(analysis.GetSuspectedFlakeDataPoint())
+
+

Powered by Google App Engine
This is Rietveld 408576698