Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: appengine/findit/model/flake/test/master_flake_analysis_test.py

Issue 2608853002: [Findit] Adding suspected CL to master flake analysis in preparation for try jobs (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/flake/test/master_flake_analysis_test.py
diff --git a/appengine/findit/model/flake/test/master_flake_analysis_test.py b/appengine/findit/model/flake/test/master_flake_analysis_test.py
index fcdace3bb54887aba7b653c4e81579031e68b6f6..08177fcc8429025bd4984dc61ed0aebf6185be4d 100644
--- a/appengine/findit/model/flake/test/master_flake_analysis_test.py
+++ b/appengine/findit/model/flake/test/master_flake_analysis_test.py
@@ -3,9 +3,12 @@
# found in the LICENSE file.
from datetime import datetime
-
+import mock
import unittest
+from gae_libs.gitiles.cached_gitiles_repository import CachedGitilesRepository
+from libs.gitiles.change_log import ChangeLog
+
from model import analysis_status
from model import result_status
from model import triage_status
@@ -154,3 +157,49 @@ class MasterFlakeAnalysisTest(unittest.TestCase):
self.assertEqual(
(master_name, builder_name),
MasterFlakeAnalysis.GetBuildConfigurationFromKey(key))
+
+ def testGetSuspectedFlakeDataPointNoSuspectedFlakeBuildNumber(self):
+ analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+ self.assertIsNone(analysis.GetSuspectedFlakeDataPoint())
+
+ def testGetSuspectedFlakeDataPoint(self):
+ expected_build_number = 123
+ data_point = DataPoint()
+ data_point.build_number = expected_build_number
+
+ analysis = MasterFlakeAnalysis.Create('m', 'b', 125, 's', 't')
+ analysis.suspected_flake_build_number = expected_build_number
+ analysis.data_points.append(data_point)
+
+ suspected_data_point = analysis.GetSuspectedFlakeDataPoint()
+ self.assertEqual(expected_build_number, suspected_data_point.build_number)
+
+ def testGetSuspectedFlakeDataPointNoDatapoint(self):
+ # This scenario should not happen.
+ expected_build_number = 123
+ unexpected_build_number = 124
+ data_point = DataPoint()
+ data_point.build_number = expected_build_number
+
+ analysis = MasterFlakeAnalysis.Create('m', 'b', 125, 's', 't')
+ analysis.suspected_flake_build_number = unexpected_build_number
+ analysis.data_points.append(data_point)
+
+ self.assertIsNone(analysis.GetSuspectedFlakeDataPoint())
+
+ @mock.patch.object(CachedGitilesRepository, 'GetChangeLog')
+ def testUpdateSuspectedCL(self, mocked_module):
+ revision = 'a1b2c3d4'
+ commit_position = 12345
+ code_review_url = 'url'
+ repo_name = 'repo_name'
+ change_log = ChangeLog(None, None, None, None, None, None, revision,
+ commit_position, None, None, code_review_url, None)
+ mocked_module.return_value = change_log
+
+ analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+ analysis.UpdateSuspectedCL(repo_name, revision)
+
+ self.assertEqual(commit_position, analysis.suspected_cl.commit_position)
+ self.assertEqual(revision, analysis.suspected_cl.revision)
+ self.assertEqual(code_review_url, analysis.suspected_cl.code_review_url)

Powered by Google App Engine
This is Rietveld 408576698