Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: appengine/findit/model/flake/master_flake_analysis.py

Issue 2608853002: [Findit] Adding suspected CL to master flake analysis in preparation for try jobs (Closed)
Patch Set: Addressing comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/flake/master_flake_analysis.py
diff --git a/appengine/findit/model/flake/master_flake_analysis.py b/appengine/findit/model/flake/master_flake_analysis.py
index 32289d3acb5b727fdafef5748cccea64b06e4cea..9add50b113071c2c6791adc03e3efcdd80273215 100644
--- a/appengine/findit/model/flake/master_flake_analysis.py
+++ b/appengine/findit/model/flake/master_flake_analysis.py
@@ -12,6 +12,7 @@ from model import triage_status
from model.base_analysis import BaseAnalysis
from model.base_build_model import BaseBuildModel
from model.base_triaged_model import TriagedModel
+from model.flake.flake_culprit import FlakeCulprit
from model.flake.flake_swarming_task import FlakeSwarmingTaskData
@@ -95,6 +96,15 @@ class MasterFlakeAnalysis(
else:
self.result_status = result_status.FOUND_INCORRECT
+ def GetDataPointOfSuspectedBuild(self):
+ """Gets the corresponding data point to the suspected flake build."""
+ if self.suspected_flake_build_number is not None:
+ for data_point in self.data_points:
+ if data_point.build_number == self.suspected_flake_build_number:
+ return data_point
+
+ return None
+
def Reset(self):
super(MasterFlakeAnalysis, self).Reset()
self.original_master_name = None
@@ -109,6 +119,8 @@ class MasterFlakeAnalysis(
self.correct_culprit = None
self.algorithm_parameters = None
self.suspected_flake_build_number = None
+ self.culprit = None
+ self.try_job_status = None
self.data_points = []
self.result_status = None
@@ -158,6 +170,15 @@ class MasterFlakeAnalysis(
# The suspected build number to have introduced the flakiness.
suspected_flake_build_number = ndb.IntegerProperty()
+ # The culprit CL associated with the try job results, if any.
+ culprit = ndb.LocalStructuredProperty(FlakeCulprit)
+
+ # The status of try jobs, if any. None if try jobs have not been triggered.
+ # Status should be PENDING or STARTED when the first try job is triggered,
+ # and COMPLETED when the last one finishes. If any try job ends in error,
+ # status will be ERROR.
+ try_job_status = ndb.IntegerProperty(indexed=False)
+
# The data points used to plot the flakiness graph build over build.
data_points = ndb.LocalStructuredProperty(
DataPoint, repeated=True, compressed=True)
« no previous file with comments | « appengine/findit/model/flake/flake_try_job_data.py ('k') | appengine/findit/model/flake/test/flake_culprit_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698