Chromium Code Reviews| Index: appengine/findit/model/flake/master_flake_analysis.py |
| diff --git a/appengine/findit/model/flake/master_flake_analysis.py b/appengine/findit/model/flake/master_flake_analysis.py |
| index 32289d3acb5b727fdafef5748cccea64b06e4cea..6bb35593db8f52595d0bc732f5f3ea24afcc0c9a 100644 |
| --- a/appengine/findit/model/flake/master_flake_analysis.py |
| +++ b/appengine/findit/model/flake/master_flake_analysis.py |
| @@ -12,6 +12,7 @@ from model import triage_status |
| from model.base_analysis import BaseAnalysis |
| from model.base_build_model import BaseBuildModel |
| from model.base_triaged_model import TriagedModel |
| +from model.flake.flake_culprit import FlakeCulprit |
| from model.flake.flake_swarming_task import FlakeSwarmingTaskData |
| @@ -95,6 +96,15 @@ class MasterFlakeAnalysis( |
| else: |
| self.result_status = result_status.FOUND_INCORRECT |
| + def GetDataPointOfSuspectedBuild(self): |
| + """Gets the corresponding data point to the suspected flake build.""" |
| + if self.suspected_flake_build_number is not None: |
| + for data_point in self.data_points: |
| + if data_point.build_number == self.suspected_flake_build_number: |
| + return data_point |
| + |
| + return None |
| + |
| def Reset(self): |
| super(MasterFlakeAnalysis, self).Reset() |
| self.original_master_name = None |
| @@ -109,6 +119,8 @@ class MasterFlakeAnalysis( |
| self.correct_culprit = None |
| self.algorithm_parameters = None |
| self.suspected_flake_build_number = None |
| + self.culprit = None |
| + self.try_job_status = None |
| self.data_points = [] |
| self.result_status = None |
| @@ -158,6 +170,12 @@ class MasterFlakeAnalysis( |
| # The suspected build number to have introduced the flakiness. |
| suspected_flake_build_number = ndb.IntegerProperty() |
| + # The culprit CL associated with the try job results, if any. |
| + culprit = ndb.LocalStructuredProperty(FlakeCulprit) |
| + |
| + # The status of the try job, if any. None if try jobs have not been triggered. |
|
chanli
2017/01/10 00:28:35
So we should have a series of try jobs, right? Whi
lijeffrey
2017/01/10 01:16:25
Since try jobs will be triggered serially, this is
chanli
2017/01/10 01:42:27
SGTM. But to be clear, could you update the commen
lijeffrey
2017/01/10 02:07:06
Done.
|
| + try_job_status = ndb.IntegerProperty(indexed=False) |
| + |
| # The data points used to plot the flakiness graph build over build. |
| data_points = ndb.LocalStructuredProperty( |
| DataPoint, repeated=True, compressed=True) |