[Findit] Adding suspected CL to master flake analysis in preparation for try jobs

appengine/findit/model/flake/flake_suspected_cl.py

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from google.appengine.ext import ndb
+
+from model.base_suspected_cl import BaseSuspectedCL
+
+
+class FlakeSuspectedCL(BaseSuspectedCL):
+  """Represents information about a flake suspected cl."""

[stgao, 2017/01/05 21:28:03]

"a suspected CL for a flake"?

As we run try job to verify, should we go with culprit instead of suspect?

[lijeffrey, 2017/01/06 05:18:16]

Renamed FlakeCulprit etc.

+
+  # Triage status for whether the CL is correct or not.
+  status = ndb.IntegerProperty(indexed=True, default=None)
+
+  # Url to the code review associated with this change.
+  code_review_url = ndb.StringProperty(indexed=False)

[stgao, 2017/01/05 21:28:03]

Based on the code below, it seems not necessarily the url to the code review. It
could be the url to the commit log too.

[lijeffrey, 2017/01/06 05:18:16]

Renamed 'url' to maintain flexibility depending what's available.

+
+  # Arguments number differs from overridden method - pylint: disable=W0221
+  @classmethod
+  def Create(cls, repo_name, revision, commit_position,
+             code_review_url):  # pragma: no cover
+    instance = super(FlakeSuspectedCL, cls).Create(
+        repo_name, revision, commit_position)
+    instance.code_review_url = code_review_url
+    return instance