Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260883006: NaCL docs: add missing generated files (Closed)

Created:
6 years, 7 months ago by JF
Modified:
6 years, 7 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Visibility:
Public.

Description

NaCL docs: add missing generated files Not all files were updated by previous commits. R= binji@chromium.org TEST= none BUG= none NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268334

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add gyp dependency to base. #

Patch Set 3 : Uploaded to wrong CL. #

Patch Set 4 : Don't touch manually updated files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M native_client_sdk/doc_generated/devguide/coding/application-structure.html View 1 chunk +4 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/message-system.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
JF
6 years, 7 months ago (2014-05-04 21:20:51 UTC) #1
binji
https://codereview.chromium.org/260883006/diff/1/native_client_sdk/doc_generated/pepper_beta/index.html File native_client_sdk/doc_generated/pepper_beta/index.html (right): https://codereview.chromium.org/260883006/diff/1/native_client_sdk/doc_generated/pepper_beta/index.html#newcode8 native_client_sdk/doc_generated/pepper_beta/index.html:8: <h2 id="pepper-c-api-reference"><a class="reference internal" href="/native-client/pepper_beta/c/index.html#pepper-beta-c-index"><em>Pepper C API Reference</em></a></h2> unfortunately, ...
6 years, 7 months ago (2014-05-05 15:31:20 UTC) #2
JF
https://codereview.chromium.org/260883006/diff/1/native_client_sdk/doc_generated/pepper_beta/index.html File native_client_sdk/doc_generated/pepper_beta/index.html (right): https://codereview.chromium.org/260883006/diff/1/native_client_sdk/doc_generated/pepper_beta/index.html#newcode8 native_client_sdk/doc_generated/pepper_beta/index.html:8: <h2 id="pepper-c-api-reference"><a class="reference internal" href="/native-client/pepper_beta/c/index.html#pepper-beta-c-index"><em>Pepper C API Reference</em></a></h2> On ...
6 years, 7 months ago (2014-05-05 23:06:38 UTC) #3
binji
lgtm, thanks
6 years, 7 months ago (2014-05-05 23:31:58 UTC) #4
JF
The CQ bit was checked by jfb@chromium.org
6 years, 7 months ago (2014-05-05 23:43:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/260883006/60001
6 years, 7 months ago (2014-05-05 23:44:49 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 00:14:54 UTC) #7
Message was sent while issue was closed. 
Change committed as 268334

Powered by Google App Engine
This is Rietveld 408576698